Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-3434) Accept ffi >= 1.16.3, < 1.17.0 #2707

Merged
merged 1 commit into from
Apr 25, 2024
Merged

(FACT-3434) Accept ffi >= 1.16.3, < 1.17.0 #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@ gem 'packaging', require: false
local_gemfile = File.expand_path('Gemfile.local', __dir__)
eval_gemfile(local_gemfile) if File.exist?(local_gemfile)

# ffi >= 1.16.0 introduces breaking changes, so we pin to the version prior
# for now
group(:integration, optional: true) do
gem 'ffi', '1.15.5', require: false
# 1.16.0 - 1.16.2 are broken on Windows
gem 'ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2', require: false
end

group(:documentation) do
Expand Down
3 changes: 2 additions & 1 deletion facter.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ Gem::Specification.new do |spec|
# or indirectly contain native extensions. The intent behind excluding these
# gems from runtime dependencies is to allow users to be able to install
# Facter without a compiler.
spec.add_development_dependency 'ffi', '1.15.5'
# ffi 1.16.0 - 1.16.2 are broken on Windows
spec.add_development_dependency 'ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rubocop', '~> 1.28' # last version to support 2.5
Expand Down