Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-3704) Customize influxdb port #56

Merged
merged 4 commits into from
Nov 2, 2022
Merged

(SUP-3704) Customize influxdb port #56

merged 4 commits into from
Nov 2, 2022

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Oct 27, 2022

This commit allows for customizing the port, which is passed to the influxdb service and all resource types.

@m0dular
Return all parameters in state of resources
7e604cc 
In 936511b, we moved a few things to optional parameters in the
resource types.  We added $use_ssl to the state of the resources in
their get() methods in another commit to make it work, and this commit
adds the rest of the parameters.
@m0dular
Pass port parameter to resources
6b391bc
@m0dular m0dular requested a review from a team as a code owner October 27, 2022 21:46
@puppet-community-rangefinder
Copy link

influxdb is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular m0dular force-pushed the SUP-3704-customize_port branch from afe5377 to 7e9e8fa Compare October 27, 2022 22:16
@MartyEwings MartyEwings changed the title Customize port (SUP-3704) Customize influxdb port Oct 28, 2022
@MartyEwings MartyEwings added the enhancement New feature or request label Oct 28, 2022
@m0dular m0dular merged commit efb92a3 into puppetlabs:main Nov 2, 2022
@m0dular m0dular mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0dular @bastelfreak @MartyEwings