Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default 90 day bucket retention #71

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Feb 13, 2023

No description provided.

@m0dular m0dular requested a review from a team as a code owner February 13, 2023 22:31
@puppet-community-rangefinder
Copy link

influxdb_bucket is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb::profile::toml is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular m0dular added the enhancement New feature or request label Feb 13, 2023
@@ -166,402 +166,6 @@
expect(provider.get(context)).to eq should_hash
end
end

# context 'with paginated api response' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's all this getting removed?

@elainemccloskey elainemccloskey merged commit a828cf1 into puppetlabs:main Feb 14, 2023
@bastelfreak
Copy link
Collaborator

@m0dular is that a breaking change that will change the retention of existing buckets from infinity to 90 days? Or only for new buckets?

@SimonHoenscheid
Copy link
Contributor

SimonHoenscheid commented Feb 15, 2023

It would be nice if the retention time would be managable via parameter. We often have use cases where data >3 months are needed

@m0dular
Copy link
Contributor Author

m0dular commented Feb 23, 2023

@bastelfreak @SimonHoenscheid Since influxdb_bucket is a resource, I don't think a parameter in the module's Puppet code could be used. You can pass your own retention_rules to any buckets that you manage, or use a resource default in your manifests to set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants