Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PA-5584]: Updated install.sh with debian-12-x86-64 changes #20

Conversation

span786
Copy link
Contributor

@span786 span786 commented Mar 15, 2024

Updated install.sh with Debian-12-x86-64 changes

@span786 span786 requested a review from a team as a code owner March 15, 2024 08:45
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your commit message to explain why the existing curl, wget, etc aren't sufficient? Should the perl changes be broken out to a separate PR?

@span786 span786 force-pushed the PA-5584-7-add-debian-12-x-86-64-to-the-install-puppet-script branch from 63295a5 to 66664c3 Compare March 18, 2024 15:15
@span786
Copy link
Contributor Author

span786 commented Mar 18, 2024

Changes to install.sh was generated using ruby install.rb command provided in the step 7 here.

I have now removed the additional changes and kept changes relevant for Debian 12

@span786 span786 requested a review from joshcooper March 18, 2024 15:19
@joshcooper joshcooper merged commit 6149ab1 into puppetlabs:main Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants