Skip to content

Conversation

@Ganneff
Copy link
Contributor

@Ganneff Ganneff commented Jan 21, 2022

This avoids triggering the notify (and as such a long log4jscanner
run) on file changes just because one puppet run is in a different
environment (say, for testing).

To allow this, we have to find the environment used in the script.
We first parse the last runs report (if exists), and if that fails we
fall back to directly asking puppet what it thinks. This way we
support both, standard environments and those that somewhat drive
around the normal mechanism of setting the environment for the agent.

This Fixes #16

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

log4jscanner is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

This avoids triggering the notify (and as such a long log4jscanner
run) on file changes just because one puppet run is in a different
environment (say, for testing).

To allow this, we have to find the environment used in the script.
We first parse the last runs report (if exists), and if that fails we
fall back to directly asking puppet what it thinks. This way we
support both, standard environments and those that somewhat drive
around the normal mechanism of setting the environment for the agent.
@Ganneff
Copy link
Contributor Author

Ganneff commented Feb 5, 2022

Closed in favor of #20

@Ganneff Ganneff closed this Feb 5, 2022
@Ganneff Ganneff deleted the no_hardcode_env branch February 5, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting environment via template considered harmful

2 participants