Improve container usability #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecate /root volume, replaced by /workspace new entrypoint script: * creates a user in the container with the same uid and gid of the volume mapped workspace directory, or the --user parameter, and runs the pdk command as that user in the container. With one exception, if the workspace directory is owned by root on the host * support for volume mapping pdk cache to /cache * failure message, if /workspace is not mapped (or writable) * warning message, if /workspace or /cache have owners or permissions that may not work * startup message, if /cache is not mounted in container (performance)
h0tw1r3
force-pushed
the
quality-of-life
branch
6 times, most recently
from
0f09829
to
5960527
Compare
|
Should address #39 |
github action workflows needs this
|
Wondering if cache should default to inside the workdir. Like |
h0tw1r3
force-pushed
the
quality-of-life
branch
3 times, most recently
from
215ad01
to
587ec94
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatically manage ownership in container to match host
deprecate /root volume, replaced by /workspace
new entrypoint script:
mapped workspace directory, or the --user parameter, and runs the pdk command
as that user in the container. With one exception, if the workspace
directory is owned by root on the host
may not work