Skip to content

Commit

Permalink
(GH-223) .travis.yml does not deploy by default
Browse files Browse the repository at this point in the history
Without this patch, the TravisCI configuration will be broken and add a
deployment section with the incorrect password and without documentation
to explain how to do deploys correctly.

Co-authored-by: Garrett Honeycutt <code@garretthoneycutt.com>
Co-authored-by: Tibor Répási <rtib@users.noreply.github.com>
  • Loading branch information
2 people authored and rodjek committed Apr 26, 2019
1 parent a54df41 commit ed32c02
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ Travis uses a .travis.yml file in the root of your repository to learn about you
|remove_branches |Allows you to remove default branches set in config_defaults.yml.|
|notifications |Allows you to specify the notifications configuration in the .travis.yml file.|
|remove_notifications |Allows you to remove default branches set in config_defaults.yml.|
|user|This string needs to be set to the Puppet Forge user name. To enable deployment the secure key also needs to be set.|
|secure|This string needs to be set to the encrypted password to enable deployment. See [https://docs.travis-ci.com/user/encryption-keys/#usage](https://docs.travis-ci.com/user/encryption-keys/#usage) for instructions on how to encrypt your password.|

### .yardopts

Expand Down
2 changes: 0 additions & 2 deletions config_defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@
stage: spec
- env: DEPLOY_TO_FORGE=yes
stage: deploy
deploy: true
user: 'puppet'
branches:
- master
- /^v\d/
Expand Down
2 changes: 1 addition & 1 deletion moduleroot/.travis.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ notifications:
<% end -%>
<% end -%>
<% end -%>
<% if @configs['deploy'] -%>
<% unless @configs['user'].nil? || @configs['secure'].nil? -%>
deploy:
provider: puppetforge
user: <%= @configs['user'] %>
Expand Down

0 comments on commit ed32c02

Please sign in to comment.