Fix newline warning in updated spec_helper and improve pre-merge CI testing #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
force-pushed
the
fixup_the_fixup
branch
2 times, most recently
from
cad7f2e
to
05567c3
Compare
bmjen
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can split this up into a couple PRs if we want, but this fixes the newly introduced "trailing newline" rubocop warning from #99 and significantly expands the Travis test suite for pdk-templates.
The new travis tests will generate a new module using pdk-templates from the PR, then generate a new instance of each time of module resource (class, provider, task, etc.), then run
pdk validateandpdk test unitto make sure everything runs cleanly.Steps 2 and 3 of the test suite continue to test that a module generated from the last release tag and from the current state of master can be converted to use the template from the PR.