Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1044) changelog functions if changelog task #118

Merged
merged 1 commit into from
Jun 25, 2018
Merged

(PDK-1044) changelog functions if changelog task #118

merged 1 commit into from
Jun 25, 2018

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Jun 25, 2018

Only run the changelog helpeer functions if we are running the changelog task

@tphoney tphoney requested a review from DavidS June 25, 2018 12:19
@DavidS
Copy link
Contributor

DavidS commented Jun 25, 2018

This will not fix the hard failure when CHANGELOG_GITHUB_TOKEN is unset

@tphoney
Copy link
Contributor Author

tphoney commented Jun 25, 2018

attempt no.2 @DavidS

DavidS
DavidS approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@bmjen bmjen merged commit c87eee3 into puppetlabs:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS approved these changes

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tphoney @DavidS @bmjen