Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1066) Use ruby 2.4.4 with travis #120

Merged
merged 1 commit into from
Jul 17, 2018
Merged

(PDK-1066) Use ruby 2.4.4 with travis #120

merged 1 commit into from
Jul 17, 2018

Conversation

vinzent
Copy link
Contributor

@vinzent vinzent commented Jul 6, 2018

This aligns with the ruby version provided by the pdk.

This aligns with the ruby version provided by the pdk.
@vinzent vinzent changed the title Use ruby 2.4.4 with travis (PDK-1066) Use ruby 2.4.4 with travis Jul 10, 2018
@vinzent
Copy link
Contributor Author

vinzent commented Jul 10, 2018

convention: rubocop: lib/puppet/provider/testprovider/testprovider.rb:4:60: Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.

is not related to this change.

this class line triggers the warning:

require 'puppet/resource_api/simple_provider'

# Implementation for the testprovider type using the Resource API.
class Puppet::Provider::Testprovider::Testprovider < Puppet::ResourceApi::SimpleProvider
  def get(_context)
    [
...

doesn't make sense to me.

@rodjek
Copy link
Contributor

rodjek commented Jul 17, 2018

That rubocop failure was due to a bug in one of rubocop's dependencies.

@rodjek rodjek merged commit 785d55c into puppetlabs:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants