Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove concat_basedir from default-facts #124

Merged
merged 1 commit into from
Sep 18, 2018
Merged

remove concat_basedir from default-facts #124

merged 1 commit into from
Sep 18, 2018

Conversation

TheMeier
Copy link
Contributor

fixes #122

DavidS
DavidS reviewed Jul 23, 2018
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#122 does not specify whether or not this will actually break folks using concat. If it does (which seems unlikely) we need to fix concat first. Otherwise this is good to go.

@TheMeier
Copy link
Contributor Author

As @glennsarti pointed out in #122 concat_basedir was removed a long time ago. I tested it with puppetlab-apache module and its tests run just fine without this fact.

@bmjen bmjen merged commit 7192a47 into puppetlabs:master Sep 18, 2018
@TheMeier TheMeier deleted the remove-concat_basedir branch April 27, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS left review comments

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default facts uses concat_basedir
3 participants
@TheMeier @DavidS @bmjen