(PDK-506) Resource API-based provider template #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-506-provider
branch
from
cef87b7
to
25575ce
Compare
DavidS
force-pushed
the
pdk-506-provider
branch
from
25575ce
to
80ca6ed
Compare
The `receive` style is more compact, and avoids duplicating setups between `allow` and `have_received`.
DavidS
force-pushed
the
pdk-506-provider
branch
2 times, most recently
from
1e36264
to
15990c6
Compare
DavidS
added a commit
to DavidS/pdk
that referenced
this pull request
Jan 22, 2018
This implements `pdk new provider` command to support use of the Resource API in modules. This requires the template changes from puppetlabs/pdk-templates#13 See the README on https://github.com/puppetlabs/puppet-resource_api for details
bmjen
suggested changes
Jan 22, 2018
There was a problem hiding this comment.
When I'm testing these template changes with puppetlabs/pdk#409. I'm getting unit test failures. Still investigating those.
UPDATE: Tests are passing now, but I had to point the Gemfile at the puppet-resource_api git repo vs getting the 0.1.0 release from rubygems.
|
v0.2.0 was just released, which should address that particular issue. |
DavidS
added a commit
to DavidS/pdk
that referenced
this pull request
Jan 25, 2018
This implements `pdk new provider` command to support use of the Resource API in modules. This requires the template changes from puppetlabs/pdk-templates#13 See the README on https://github.com/puppetlabs/puppet-resource_api for details
DavidS
force-pushed
the
pdk-506-provider
branch
from
15990c6
to
954217f
Compare
bmjen
approved these changes
Jan 29, 2018
nabertrand
pushed a commit
to umnmsi/pdk-templates
that referenced
this pull request
Oct 17, 2023
enabling coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.