Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1269) Add plan template #184

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Conversation

npwalker
Copy link
Contributor

No description provided.

TargetSpec $parameter2,
) {

run_task('modulename::task_name', $parameter1, some_parameter_name => $parameter2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to check if we pass in the module name to the config hash, would be nice to fill in the modulename::task_name part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just some made up boiler plate of how someone would put a task in a plan. However, up on line 10 it only passes though the name of the plan but without namespacing and we really have to fix that.

https://github.com/puppetlabs/pdk-templates/pull/184/files#diff-41c11f3567ed263cffeae409027787f8R10

I think what the template for a plan should look like is something I'd want the bolt maintainers to provide. Since it can run tasks, scripts, commands, puppet apply there's no one size fits all template but I think we want to get a small snippet of each ideally so the user can copy /paste.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree. I'll merge this to get something boilerplate in, and we can address more codified templates of plans, tasks, and tests with the Bolt team.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from afar.

Eventually this should also have a plan_spec.erb.

Also, not quite sure how the rendering code reacts on its absence, but that can be handled when adding the pdk new plan command over there.

TargetSpec $parameter2,
) {

run_task('modulename::task_name', $parameter1, some_parameter_name => $parameter2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree. I'll merge this to get something boilerplate in, and we can address more codified templates of plans, tasks, and tests with the Bolt team.

@bmjen bmjen merged commit 08be40b into puppetlabs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants