Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-196) Fix style for classes and defined types #197

Merged
merged 1 commit into from
Mar 4, 2019
Merged

(GH-196) Fix style for classes and defined types #197

merged 1 commit into from
Mar 4, 2019

Conversation

ghoneycutt
Copy link
Contributor

No description provided.

@ghoneycutt
Copy link
Contributor Author

Fixes #196

rodjek
rodjek approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is explicitly mentioned in the style guide, but it is the style used in the examples 👍

/cc @jbondpdx on possible style guide change to make this explicit?

@rodjek rodjek merged commit 01199f0 into puppetlabs:master Mar 4, 2019
@ghoneycutt ghoneycutt deleted the 196_fix_style branch March 4, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghoneycutt @rodjek