(FM-7847) adding puppet_litmus defaults #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
suggested changes
Mar 14, 2019
There was a problem hiding this comment.
Please split out the re-ordering of the config_defaults.yml into a separate commit. Otherwise it's really hard to see what you changed there.
Some of those also only depend on whether sorting includes ., or is case sensitive. In these cases, it might not be worth the effort at all to change the sort order.
DavidS
approved these changes
Mar 21, 2019
ghoneycutt
pushed a commit
to ghoneycutt/pdk-templates
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also alphabetising lists in config_defaults for easier reading