Remove leading whitespace from README template #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Apr 3, 2019
| @@ -1,4 +1,4 @@ | |||
| <% name = @configs['module_metadata']['name'].split('-').last rescue '[modulename]' %> | |||
| <%- name = @configs['module_metadata']['name'].split('-').last rescue '[modulename]' -%> | |||
There was a problem hiding this comment.
I don't believe you want <%-Just -%> at the end to remove newlines.
Don't see why we want this line at all though since we have # name below it.
There was a problem hiding this comment.
The reason for the PR is because without it, you end up with a rendered file with a single blank line starting the file like this:
# Template
Welcome to your new module...
Agreed the leading <%- isn't required, it's a style I personally use for all code tags in erb templates to prevent superfluous whitespace from being rendered should the block be indented.
scotje
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generated, the README.md will have a leading newline.