Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1416) Support Gemfile source option #262

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Jun 27, 2019

Add the ability to specify a per-gem source where needed.

Add the ability to specify a per-gem source where needed.
@seanmil seanmil changed the title Support Gemfile source option (PDK-1416) Support Gemfile source option Jun 28, 2019
@scotje
Copy link
Contributor

scotje commented Jul 2, 2019

@seanmil Thanks for the contribution! Would you mind adding something about this option to the README? Once we have that I think this will be ready to merge.

@seanmil
Copy link
Contributor Author

seanmil commented Jul 2, 2019

I don't mind adding something about it, but none of the other gem options are documented anywhere in the PDK that I could see. I would have expected them around here: https://github.com/puppetlabs/pdk-templates#gemfile

How would you think that should look? Another table in the Gemfile section or something else?

@scotje
Copy link
Contributor

scotje commented Jul 2, 2019

Indeed the existing options don't appear to be documented at all :)

I agree that the section you linked would be the best place for it. I think if we add an example below the existing table and then a new table that lists the options for each entry that would be good. If you want I can work on adding docs for the existing items but if you want to take a pass at it please feel free!

@seanmil
Copy link
Contributor Author

seanmil commented Jul 5, 2019

I've added documentation for all of the options in a gem item, an example in the examples area, and clarified a couple of other points around specifying custom gems which I felt could have been a little clearer. Let me know. Thanks!

Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @seanmil, I added one suggestion to fix a typo and add a link to Rubygems docs on version ranges. Looks like CI is failing but I haven't had a chance to look at that yet.

README.md Outdated Show resolved Hide resolved
Add/clarify gem specification for Gemfile customization.
@scotje scotje merged commit b096033 into puppetlabs:master Jul 16, 2019
@scotje
Copy link
Contributor

scotje commented Jul 16, 2019

Thanks for your contribution to PDK @seanmil!

@rodjek rodjek added this to the 1.12.0 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants