Make deploy optional in .travis.yml

[ardrigh]

Deployments from CI to the Puppet Forge should be configured as opt-in. A lot of internal or private modules will not want these lines is the CI configuration.

Also add the option to specify a valid username along with the secure password.

For any users wanting to add the deploy section, adding the deploy keys to .sync.yml and running pdk update works.

❱ cat .sync.yml

.travis.yml:
  deploy: true
  user: deploy_user
  secure: deploy_password

❱ cat update_report.txt

/* Report generated by PDK at 2018-03-07 11:17:49 +1300 */


--- .travis.yml	2018-03-07 11:17:46.306683603 +1300
+++ .travis.yml.pdknew	2018-03-07 11:17:49.138287398 +1300
@@ -37,4 +37,13 @@
     - /^v\d/
 notifications:
   email: false
+deploy:
+  provider: puppetforge
+  user: deploy_user
+  password:
+    secure: "deploy_password"
+  on:
+    tags: true
+    all_branches: true
+    condition: "$DEPLOY_TO_FORGE = yes"⏎ 

[edestecd]

👍 Please merge this...

[edestecd]

@ardrigh do you need to add some defaults to: https://github.com/puppetlabs/pdk-templates/blob/master/config_defaults.yml

[bmjen]

@ardrigh I like these changes, but I think the defaulting needs to be to true and the username to puppet, so that we can maintain compatibility for those PDK users that currently rely on this setting.

[bmjen]

Needs defaults to maintain backward compatibility.

[ardrigh]

@bmjen I added the defaults to config_defaults.yml and did some brief testing.

A new module is created with the deploy section.

If the deploy section is deleted, pdk update will add it again with the defaults.

If a user creates .sync.yml:

• pdk update will add the section with the default user: puppet if deploy: true

.travis.yml:
  deploy: true

• pdk update will add the section if user name is specified

.travis.yml:
  user: 'foo'

• pdk update will remove the deploy section if deploy: false

.travis.yml:
  deploy: false

Is that suitable, or would you prefer to have the defaults in the template?

Note: I rebased the branch from the current master to fix conflict on config_defaults.yml

[edestecd]

👍

[bmjen]

Thanks @ardrigh ! That's perfect. I just wanted to make sure previous behavior is maintained, which is... a PDK user that created a new module with the older templates, does not need to add a .sync.yml update in order to keep their module configuration the same.