Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#348) Add .devcontainer for vscode #349

Merged
merged 1 commit into from
Sep 21, 2020
Merged

(#348) Add .devcontainer for vscode #349

merged 1 commit into from
Sep 21, 2020

Conversation

silug
Copy link
Contributor

@silug silug commented Sep 21, 2020

Fixes #348.

@silug silug requested review from a team as code owners September 21, 2020 19:08
michaeltlombardi
michaeltlombardi approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm way into this, would absolutely use devcontainers if they were available. 🎉 this is awesome!

@michaeltlombardi michaeltlombardi merged commit b364a1f into puppetlabs:main Sep 21, 2020
@silug silug mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpogran jpogran jpogran approved these changes

@binford2k binford2k binford2k approved these changes

@michaeltlombardi michaeltlombardi michaeltlombardi approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .devcontainer for vscode
5 participants
@silug @jpogran @binford2k @michaeltlombardi @david22swan