Update Github Actions auto_release workflow #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carabasdaniel
force-pushed
the
auto_releasewf
branch
2 times, most recently
from
80696d6
to
673e5cd
Compare
carabasdaniel
pushed a commit
to puppetlabs/puppetlabs-testing
that referenced
this pull request
Feb 4, 2021
carabasdaniel
force-pushed
the
auto_releasewf
branch
from
673e5cd
to
88bf6fb
Compare
carabasdaniel
pushed a commit
to puppetlabs/puppetlabs-testing
that referenced
this pull request
Feb 4, 2021
|
Successful workflow run: https://github.com/puppetlabs/puppetlabs-testing/runs/1832174668?check_suite_focus=true |
sanfrancrisko
approved these changes
Feb 4, 2021
david22swan
approved these changes
Feb 5, 2021
DavidS
suggested changes
Feb 5, 2021
| run: | | ||
| git config --local user.email "action@github.com" | ||
| git config --local user.name "GitHub Action" | ||
| git add . | ||
| git commit -m "Auto-Release prep" | ||
|
|
||
| - name: "Get Version" | ||
| if: ${{ github.repository_owner == '<%= common['owner'] %>' }} | ||
| id: gv | ||
| run: | | ||
| echo "::set-output name=ver::$(cat metadata.json | jq .version)" |
There was a problem hiding this comment.
Suggested change
| echo "::set-output name=ver::$(cat metadata.json | jq .version)" | |
| echo "::set-output name=ver::$(cat metadata.json | jq .version | tr -d \")" |
remove additional quotes from result:
| branch: "release-prep" | ||
| delete-branch: true | ||
| title: "Auto-release prep ${{ steps.gv.outputs.ver }}" | ||
| title: "Release prep v${{ steps.gv.outputs.ver }}" |
There was a problem hiding this comment.
Suggested change
| title: "Release prep v${{ steps.gv.outputs.ver }}" | |
| title: "Release prep v${{ steps.gv.outputs.ver }}" | |
| body: "Automated release-prep through [pdk-templates](https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.github/workflows/auto_release.yml.erb)" |
Avoid advertising for others when we can advertise for our own stuff.
There was a problem hiding this comment.
extra points for extracting the generated changelog bits of this release and add them to the text here.
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| commit-message: "Auto-release prep" | ||
| commit-message: "Release prep v${{ steps.gv.outputs.ver }}" | ||
| branch: "release-prep" |
There was a problem hiding this comment.
Suggested change
| branch: "release-prep" | |
| branch: "release-prep" | |
| delete-branch: true |
clean up afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments on PR: #393 (review)