added more fine-grained control of custom_before_steps

[skoef]

Give the option to define custom_before_steps as either an array or a hash to give more fine-grained control over the order of execution of the custom steps.

Solves #435

[sanfrancrisko]

Thanks for the enhancement @skoef

[cdenneen]

@skoef I just tried to add this to my .sync.yml but it yielded "No changes" when running a pdk update. Is this the correct syntax?

diff --git i/.sync.yml w/.sync.yml
index a653003..4842072 100644
--- i/.sync.yml
+++ w/.sync.yml
@@ -95,6 +95,8 @@ Rakefile:
   custom:
     image: private.jfrog.io/docker/ap/pdk-docker:latest
     default_before_script: false
+    custom_before_steps:
+      - pdk bundle exec puppet config set forge_authorization "Bearer $PUPPET_READ_TOKEN" --section main
     cache:
       paths:
       - /root/.pdk/cache

❯ pdk update
No changes required.

[skoef]

@cdenneen I think this has something to do with the default_before_script you have specified there. The default before script is omitted at all so it is completely up to you to specify it.

[cdenneen]

@skoef shouldn’t the default and custom be mutually exclusive? I might not want what’s in the default but I might want some custom before/after scripts.

[skoef]

Basically, when disabling the default before_script, you have to define the before_scripts of your jobs anyway, so you should be in full control of the steps.

However, that default_before_script functionality is not something that was touched by this MR nor something I have an opinion about (I dó use the default before_script), so I suggest you open an issue to discuss this.