allow to configure rspec-puppet's facter_implementation #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chelnak perhaps you could take a look at this MR? Thanks! |
|
@skoef This seems like a sensible addition! Please could you add a little more info to the docs? |
skoef
force-pushed
the
facterImplementation
branch
from
39fcf37
to
7f96ab7
Compare
|
@chelnak Something like this? |
|
|
skoef
force-pushed
the
facterImplementation
branch
from
7f96ab7
to
207da83
Compare
|
@chelnak I had forgotten about this PR completely until the CLAassistant suddenly remembered me about it, nearly a half year later. I think this can be merged now, right? |
|
Hey! Yes I will merge this once we get the next PDK release out of the door. |
chelnak
suggested changes
Jan 18, 2023
chelnak
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading this article made me want to try the setting out. My CI job went from 5min40s to 2min37s so I was easily sold. This PR makes it possible to configure it through PDK templates.