Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-885) pdk-templates v3 prep #510

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Apr 24, 2023

This PR prepares PDK templates for the next release.

Module dependencies have been updated and a number of features that are not used by puppetlabs have been removed.

@chelnak chelnak self-assigned this Apr 24, 2023
@chelnak chelnak requested a review from a team as a code owner April 24, 2023 20:01
@chelnak chelnak force-pushed the CONT-885-pdk_templates_3_prep branch from caefdee to 96e632f Compare April 24, 2023 20:04
@chelnak chelnak closed this Apr 25, 2023
@chelnak chelnak reopened this Apr 25, 2023
@chelnak chelnak force-pushed the CONT-885-pdk_templates_3_prep branch 5 times, most recently from dacde4a to d0efd9e Compare April 25, 2023 14:07
@chelnak chelnak force-pushed the CONT-885-pdk_templates_3_prep branch from d0efd9e to dfd4c16 Compare April 25, 2023 14:15
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the rubocop.yml this looks good.

It'll need more work to implement the NewCops: enable approach we're taking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants