-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-885) pdk-templates v3 prep #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-885-pdk_templates_3_prep
branch
from
April 24, 2023 20:04
caefdee
to
96e632f
Compare
chelnak
force-pushed
the
CONT-885-pdk_templates_3_prep
branch
5 times, most recently
from
April 25, 2023 14:07
dacde4a
to
d0efd9e
Compare
chelnak
force-pushed
the
CONT-885-pdk_templates_3_prep
branch
from
April 25, 2023 14:15
d0efd9e
to
dfd4c16
Compare
jordanbreen28
approved these changes
Apr 25, 2023
david22swan
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the rubocop.yml this looks good.
It'll need more work to implement the NewCops: enable
approach we're taking
LukasAud
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares PDK templates for the next release.
Module dependencies have been updated and a number of features that are not used by puppetlabs have been removed.