Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Gitlab CI improvements #76

Merged
merged 9 commits into from
May 9, 2018
Merged

Conversation

dhollinger
Copy link
Contributor

Added following improvements:

  • .gitlab-ci.yml documentation added to the README.md
  • Added code to .gitlab-ci.yml.erb to allow for users to override the defaults completely if they so choose.

@dhollinger dhollinger force-pushed the gitlab_ci branch 2 times, most recently from 3c1c523 to dcc1f0b Compare May 3, 2018 21:25
@DavidS
Copy link
Contributor

DavidS commented May 4, 2018

@cdenneen I can't add you as a reviewer, but can you give 👍 here, if this change is ok now?

Copy link
Contributor

@cdenneen cdenneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhollinger anyway to make that matrix more of a "matrix" (array) rather than all the duplication of lines?

Copy link
Contributor

@cdenneen cdenneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global variables look good 👍

@dhollinger
Copy link
Contributor Author

@cdenneen I'm thinking of how to do that still before I add anything. It would take some work as Gitlab CI doesn't support matrices the way Travis does. Gitlab CI operates in Pipelines (connected jobs) rather than a bunch of one-off "build" jobs (Just comparing to my experience with both).

@cdenneen
Copy link
Contributor

cdenneen commented May 4, 2018

yeah so you'd still have something like

stages:
  - validate
  - metadata
  - unit
  - acceptance

ruby_versions:
  2.1.9:
  puppetversion: 4.10.11
  2.4.3:
  puppetversion: 5.5.1

and then some way of doing

for each stage
for each ruby version
for each puppet version

so the jobs come out as

validate puppet 4
validate puppet 5
metadata puppet 4
metadata puppet 5
unit puppet 4
unit puppet 5
acceptance puppet 4
acceptance puppet 5

@dhollinger dhollinger force-pushed the gitlab_ci branch 2 times, most recently from 154bdec to eb5b517 Compare May 4, 2018 20:29
@DavidS DavidS merged commit fa8e3ec into puppetlabs:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants