Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-r10k to 4.1.0 #927

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

alex501212
Copy link
Contributor

Updated rubygem-r10k from 3.16.2 to 4.1.0.

@alex501212 alex501212 requested review from a team as code owners October 31, 2024 10:30
Copy link
Contributor

@danadoherty639 danadoherty639 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc
Copy link
Contributor

We will need to adjust bolt's gemspec to accomidate this or this will fail https://github.com/puppetlabs/bolt/blob/ce9235a197ced97da6a68c335fe65144d4885941/bolt.gemspec#L63 . We will need to coordinate the merges.

Normally for a major version bump like this I wouls say we should continue to ship the 3 series in PE. However given we dont actually use that part of bolt there and the 2021.7.x stream is nearly EOL we can just ship one version safely.

@donoghuc
Copy link
Contributor

We may want to wait for r10k 5 which may be comming next week.

cc @justinstoller

@alex501212 alex501212 merged commit f71de6c into puppetlabs:master Nov 7, 2024
3 checks passed
@alex501212 alex501212 deleted the r10k-bump branch November 7, 2024 12:28
@alex501212 alex501212 restored the r10k-bump branch November 11, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants