(#302) Fix warnings generated by ERB.new #308
Merged
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Sep 26, 2022
danielparks
force-pushed
the
fix_erb
branch
from
5e1a958 to
9c437cf
Compare
This has to special case Ruby <2.6.0 since those versions will interpret the keyword argument as a hash passed as the second argument. Without this change running this code in Ruby 2.6+ will generate warnings about the parameters passed to `ERB.new`.
|
@chelnak since this causes a lot of noise on ruby3, could you do a new release please? |
|
Ideally I would like to cut a new release for this today. There are some other clean-up tasks that I want to sort out first though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to special case Ruby <2.6.0 since those versions will interpret the keyword argument as a hash passed as the second argument.
Without this change running this code in Ruby 2.6+ will generate warnings about the parameters passed to
ERB.new.I’ve run the tests under Ruby 2.3.0 (with some dificulty; see #301) and this appears to work. At the very least it clears up all the warnings.