Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://forgeapi.puppet.com/private/versions/puppet-agent is outdated #9395

Closed
bastelfreak opened this issue Jun 14, 2024 · 7 comments
Closed
Labels
bug Something isn't working triaged Jira issue has been created for this

Comments

@bastelfreak
Copy link
Contributor

bastelfreak commented Jun 14, 2024

Describe the Bug

rspec-puppet-facts pull in https://forgeapi.puppet.com/private/versions/puppet-agent after each new puppet/facter release. The file is used within rspec-puppet unit tests to determine the correct facter version in relation to the specified puppet version (then the facter version is used to get the correct factset from facterdb). The latest 8.x entry is 8.3.1, latest 7.x is 7.27.0. Please update the file

Expected Behavior

A parseable overview of components in recent Puppet releases.

Steps to Reproduce

  • curl --silent https://forgeapi.puppet.com/private/versions/puppet-agent | jq .

Environment

Additional Context

@bastelfreak bastelfreak added the bug Something isn't working label Jun 14, 2024
@smortex
Copy link
Contributor

smortex commented Jun 14, 2024

Oh! I wasn't aware of this API and I guess I could rely on it to make it easier for me to handle the FreeBSD packages (replacing this tedious manual state with another simpler one).

@cthorn42
Copy link
Collaborator

For reference, https://github.com/puppetlabs/puppet-forge-api/blob/main/app/static/puppet_agent_components.json, looks to be the source of truth. That was being updated through 2022 by automation and stopped at some point. There was a manual update at one point in 2023 and nothing since then.
I think we can for sure push up a manual update, but better yet would be figuring out what happened with the automation around this.

@bastelfreak
Copy link
Contributor Author

@cthorn42 can you do the manual release and let me know when the updated file is available? I can afterwards make a new release for rspec-puppet-facts.

@tvpartytonight tvpartytonight added the triaged Jira issue has been created for this label Jun 18, 2024
Copy link

Migrated issue to PUP-12052

@cthorn42
Copy link
Collaborator

My commit that added the 8.7.0 release to that private file was merged last week but I'm not seeing a change in the https://forgeapi.puppet.com/private/versions/puppet-agent. I was hoping for a quick fix but that isn't the case, I will need to get some help from someone on the Forge to figure out what else needs done.

@bastelfreak
Copy link
Contributor Author

now with the 8.8.1 release the file is outdated again.

bastelfreak added a commit to bastelfreak/rspec-puppet-facts that referenced this issue Aug 4, 2024
This was generated with:
```
bundle exec rake puppet_versions:update
```

Puppet 8.8.1 is currently missing: puppetlabs/puppet#9395
bastelfreak added a commit to bastelfreak/rspec-puppet-facts that referenced this issue Aug 4, 2024
This was generated with:
```
bundle exec rake puppet_versions:update
```

Puppet 8.8.1 is currently missing: puppetlabs/puppet#9395
@AriaXLi
Copy link
Contributor

AriaXLi commented Aug 27, 2024

Hi @bastelfreak thanks for opening this issue! I've updated our internal documentation to make sure we manually update https://github.com/puppetlabs/puppet-forge-api/blob/main/app/static/puppet_agent_components.json so we hopefully won't run into this again so I'll close out this issue now.

@AriaXLi AriaXLi closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Jira issue has been created for this
Projects
None yet
Development

No branches or pull requests

5 participants