(PUP-8591) Remove webrick #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarlisle
changed the title
|
jenkins please test this |
pcarlisle
force-pushed
the
remove-webrick
branch
from
5533c26
to
ff17d86
Compare
|
CLA signed by all contributors. |
This removes the basic webrick and rack code. There may be other code that is made dead by this commit.
pcarlisle
force-pushed
the
remove-webrick
branch
from
ff17d86
to
fd372ff
Compare
|
jenkins please test this |
pcarlisle
changed the title
pcarlisle
force-pushed
the
remove-webrick
branch
from
fd372ff
to
1ddb109
Compare
|
jenkins please test this |
2 similar comments
|
jenkins please test this |
|
jenkins please test this |
pcarlisle
force-pushed
the
remove-webrick
branch
from
1ddb109
to
354e9be
Compare
|
jenkins please test this |
joshcooper
reviewed
Apr 26, 2018
| it "should fail if the indirection does not have the correct version" do | ||
| expect(lambda { handler.uri2indirection("GET", "#{Puppet::Network::HTTP::CA_URL_PREFIX}/v3/certificate/foo", params) }).to raise_error(bad_request_error) | ||
| end | ||
|
|
There was a problem hiding this comment.
This test seems valuable, eg trying to get version 4 of the regular puppet routes?
joshcooper
approved these changes
Apr 26, 2018
Some limited knowledge of the ca routes remains so that the agent can talk to puppetserver which still implements these.
I originally found this method hard to read. I've tried to have this function at a single level of abstraction. The only apparent functional difference is removing the call to cleanup. This is no longer used by anything.
pcarlisle
force-pushed
the
remove-webrick
branch
from
354e9be
to
6cc73d5
Compare
|
added back the one unit test, not going to rerun acceptance since no code has changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.