(PUP-11944) Update hostcert_renewal_interval puppet setting docs
#9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the documentation of the setting implies that the certificate will be refreshed every N days (N = specified duration). However, it actually only renews the client cert if the cert expires within N days from now. This commit updates the documentation for hostcert_renewal_interval in defaults.rb to more closely reflect how the setting behaves.
joshcooper
approved these changes
Oct 3, 2023
AriaXLi
deleted the
PUP-11944/update_hostcert_renewal_interval_documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation of the setting implies that the certificate will be refreshed every N days (N = specified duration). However, it actually only renews the client cert if the cert expires within N days from now.
This commit updates the documentation for hostcert_renewal_interval in defaults.rb to more closely reflect how the setting behaves.