Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Don't escape the $ in versioncmp doc #9137

Merged
merged 1 commit into from
Nov 4, 2023
Merged

(maint) Don't escape the $ in versioncmp doc #9137

merged 1 commit into from
Nov 4, 2023

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Oct 27, 2023

No description provided.

@evgeni evgeni requested a review from a team as a code owner October 27, 2023 11:31
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@evgeni
Copy link
Contributor Author

evgeni commented Oct 27, 2023

@joshcooper an easy one for you 😁

joshcooper
joshcooper approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @evgeni!

@joshcooper joshcooper merged commit 9dae140 into puppetlabs:7.x Nov 4, 2023
12 checks passed
@evgeni evgeni deleted the patch-1 branch November 4, 2023 06:08
@joshcooper joshcooper added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evgeni @puppetlabs-jenkins @bastelfreak @joshcooper