(PUP-11768) More Rubocop layout cops #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
PUP-11768/main/more-layout-cops
branch
from
68c7711 to
0eee2b5
Compare
mhashizume
force-pushed
the
PUP-11768/main/more-layout-cops
branch
5 times, most recently
from
5e9a440 to
8a64d2d
Compare
This commit enables the Rubocop Layout/ClosingParenthesisIndentation cop.
This commit enables the Rubocop Layout/CommentIndentation cop.
This commit enables the Rubocop Layout/DotPosition cop.
This commit enables the Rubocop Layout/ElseAlignment cop. In some instances (like Puppet::Pal::TaskSignature.runable_with? and Puppet::Transaction::Report.initialize_from_hash), the new alignment pushed code past the 80 character line length recommended by the Ruby style guide and was reformatted to accomodate that.
This commit enables the Rubocop Layout/EmptyLineBetweenDefs cop.
This commit enables the Rubocop Layout/EmptyLines cop.
This commit enables the Rubocop Layout/EmptyLinesAroundAccessModifier cop.
This commit enables the Rubocop Layout/EmptyLinesAroundArguments cop.
This commit enables the Rubocop Layout/EmptyLinesAroundAttributeAccessor cop and fixes all offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundBeginBody cop and fixes the two offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundBlockBody cop and addresses all offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundClassBody cop and addresses all offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundExceptionHandlingKeywords cop and addresses all offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundMethodBody cop and addresses all offenses.
This commit enables the Rubocop Layout/EmptyLinesAroundModuleBody cop and addresses all offenses.
mhashizume
force-pushed
the
PUP-11768/main/more-layout-cops
branch
from
8a64d2d to
584abe3
Compare
This commit enables the Rubocop Layout/EmptyLineAfterGuardClause cop and fixes all offenses.
This commit enables the Rubocop Layout/EmptyLineAfterMagicComment cop and fixes all offenses.
joshcooper
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR largely comprises cops related to empty lines, so the scope is broad but the changes are mostly related to newlines.