Remove Accept-Encoding header on redirect #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
reviewed
Feb 26, 2024
mhashizume
force-pushed
the
PUP-11983/main/http-redirects
branch
from
80dfd31 to
7b4e033
Compare
|
This will need to be backported to 7.x after merge. |
mhashizume
force-pushed
the
PUP-11983/main/http-redirects
branch
from
7b4e033 to
fa6871c
Compare
AriaXLi
approved these changes
Feb 26, 2024
mhashizume
force-pushed
the
PUP-11983/main/http-redirects
branch
from
bd7c7da to
fa6871c
Compare
|
Blocked on #9266 |
|
Needs rebase on main |
Prior to this commit, Puppet would copy all request headers in an HTTP redirect, including Accept-Encoding. In some cases when HTTP compression was enabled, the response would fail to get decompressed, then would fail to get parsed and trigger a vague error. This commit strips the Accept-Encoding headers on redirect, allowing Ruby's built-in Net::HTTP to both compress and decompress the traffic.
mhashizume
force-pushed
the
PUP-11983/main/http-redirects
branch
from
fa6871c to
d0a73bb
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, Puppet would copy all request headers in an HTTP redirect, including Accept-Encoding. In some cases when HTTP compression was enabled, the response would fail to get decompressed, then would fail to get parsed and trigger a vague error.
This commit strips the Accept-Encoding headers on redirect, allowing Ruby's built-in Net::HTTP to both compress and decompress the traffic.
Resolves #9143