(#9292) New command line flag for puppet resource, fail #9297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! |
Since strict defaults to true in puppet8 I think that would be a breaking change. |
joshcooper
reviewed
Mar 15, 2024
joshcooper
reviewed
Mar 15, 2024
See discussion in issue puppetlabs#9292. What this PR adds is the ability for on the command line if --fail is passed then the `puppet resource` command will exit with a non zero return code.
cthorn42
force-pushed
the
maint/main/puppet_resource_service_returns_correctly
branch
from
0b3d25a
to
cf6cb77
Compare
joshcooper
approved these changes
Mar 19, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9297-to-7.x origin/7.x
cd .worktree/backport-9297-to-7.x
git checkout -b backport-9297-to-7.x
ancref=$(git merge-base 1a53bf7d66275ad4b4928484bb1314dc32e84677 cf6cb773c327098ee850fbffb17ce3564895dfa4)
git cherry-pick -x $ancref..cf6cb773c327098ee850fbffb17ce3564895dfa4 |
|
Backport PR #9300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in issue #9292.
What this PR adds is the ability for on the command line if --fail is passed then the
puppet resourcecommand will exit with a non zero return code.