Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validate_data_hash to return modified hash #9326

Merged
merged 2 commits into from
May 3, 2024
Merged

Update validate_data_hash to return modified hash #9326

merged 2 commits into from
May 3, 2024

Commits on May 3, 2024

  1. Update validate_data_hash to return modified hash 

    Puppet::Pops::Lookup::ModuleDataProvider#validate_data_hash is a method
that is supposed to prune a data hash of any keys that are not prefixed
with a given module's name. However prior to this commit it incorrectly
took the data hash, cloned it, operated on the clone, then returned the
unchanged original hash.

This commit updates validate_data_hash to instead return the modified
hash, and updates the warning message generated when a key is pruned to
include the key.
    @mhashizume
    mhashizume committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d8bbc1e View commit details
    Browse the repository at this point in the history

  2. Simplify select.map to filter_map 

    This commit simplifies instances where map is called on a select call to
instead use filter_map.
    @mhashizume
    mhashizume committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7a86ebf View commit details
    Browse the repository at this point in the history