(PUP-12047) Add logic to skip MD5 checksum method on a FIPS system #9409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logic in http_metadata.rb to skip MD5 related checksums when FIPS is enabled since MD5 is not supported on FIPS enabled systems. Additionally, a test is added to http_metadata_spec.rb that checks that the MD5 checksum type is skipped on FIPS enabled platforms. Cherry picked from two commits: (cherry picked from commit 1f7c8ef) (cherry picked from commit fa721be)
joshcooper
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic in http_metadata.rb to skip MD5 related checksums when FIPS is enabled since MD5 is not supported on FIPS enabled systems. Additionally, a test is added to http_metadata_spec.rb that checks that the MD5 checksum type is skipped on FIPS enabled platforms.
Cherry picked from two commits:
(cherry picked from commit 1f7c8ef)
(cherry picked from commit fa721be)