Check fixes #9526
Merged
Check fixes #9526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URI gem recently updated its error messages to include a space where there previously was not one: ruby/uri@9f2c7ed This commit updates our test to reflect that change. (cherry picked from commit c3a5090)
The JSON gem has historically included newlines when pretty printing empty arrays or hashes. This changed with ruby/json@b2c4480 in JSON 2.8.0. In order to maintain consistent behavior for our users, this commit special cases empty array and hash facts and adds a new test for empty hashes. (cherry picked from commit 295d2f9)
Rubocop recently started flagging several files for violations of the Style/AccessModifierDeclarations cop. This only occurs in 7.x as many Rubocop fixes have landed in main/8.x. Because 7.x is so close to its end-of-life, these violations aren't really worth fixing and this commit excludes them from the cop.
cthorn42
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises several fixes for tests and checks including: