This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Use a healthcheck as recommended by the puppet-grafana docs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genebean
force-pushed
the
http_conn_validator
branch
from
51b7124
to
8236a6c
Compare
genebean
force-pushed
the
http_conn_validator
branch
from
8236a6c
to
a572d75
Compare
genebean
force-pushed
the
http_conn_validator
branch
from
a572d75
to
27b819e
Compare
|
Should have done this earlier, my mistake. Tests should pass now: |
genebean
force-pushed
the
http_conn_validator
branch
from
27b819e
to
2bceb50
Compare
|
Annnd now it seems that the node declaration in |
genebean
force-pushed
the
http_conn_validator
branch
from
2bceb50
to
5f1873b
Compare
|
Testing: Fresh CentOS 7, all defaults Fresh CentOS 7, custom password, add dashboards I logged into the web interface to verify the pw and the dashboards |
genebean
force-pushed
the
http_conn_validator
branch
from
8148113
to
42ab534
Compare
suckatrash
suggested changes
Jan 15, 2019
|
|
||
| exec { 'update Grafana admin password': | ||
| path => '/usr/bin', | ||
| command => @("CHANGE_GRAFANA_PW"), |
There was a problem hiding this comment.
Still seeing issues with this on the initial run
Error: /Stage[main]/Puppet_metrics_dashboard::Grafana/Exec[update Grafana admin password]: Failed to call refresh: 'curl -X PUT -H "Content-Type: application/json" -d '{
"oldPassword": "admin",
"newPassword": "admin",
"confirmNew": "admin"
}' http://admin:admin@localhost:8080/api/user/password
' returned 7 instead of one of [0]
and attempting to change the password:
Error: /Stage[main]/Puppet_metrics_dashboard::Post_start_configs/Grafana_datasource[influxdb_telegraf]: Could not evaluate: Fail to retrieve datasources (HTTP response: 401/{"message":"Invalid username or password"})
There was a problem hiding this comment.
What's your test methodology here? I ask cause, as shown in the output above, a single pass works fine on CentOS 7.
There was a problem hiding this comment.
This is a vmpooler host (Debian 9) running against a 2018.1.5 master. I did notice that the compiled catalog looks a little odd wrt the exec resource in the puppet_metrics_dashboard::grafana class:
"parameters": {
"command": "curl -X PUT -H \"Content-Type: application/json\" -d '{\n \"oldPassword\": \"admin\",\n \"newPassword\": \"password\",\n \"confirmNew\": \"password\"\n}' http://admin:admin@localhost:3000/api/user/password\n",
"cwd": "/usr/share/grafana",
"path": "/usr/bin",
"refreshonly": true
},
Maybe the line breaks are the problem?
There was a problem hiding this comment.
Shouldn't be but at least now I've got an idea on what to look at.
genebean
force-pushed
the
http_conn_validator
branch
2 times, most recently
from
c535d39
to
55a5521
Compare
|
@suckatrash Sorry for the hiatus! I have just rebased this on current master. Will you see if you are still having problems? If the admin stuff is still messing up it might be better to abandon that aspect of this and just use the task that I got added to the Grafana module via voxpupuli/puppet-grafana#148 |
|
Just tested this and I think in the agent run Cool that you got a task added! Want to just go with the healthcheck changes since that's a nice improvement? Or maybe some added ordering could solve the problem above? |
genebean
force-pushed
the
http_conn_validator
branch
from
55a5521
to
6c08dfa
Compare
|
Running some tests now to see if some simple ordering will help |
genebean
force-pushed
the
http_conn_validator
branch
3 times, most recently
from
bd1c2ff
to
9610367
Compare
|
@suckatrash try this one please |
|
@genebean I'm getting the same error as before :( |
|
Can we pair on this @suckatrash as there seems to be a serious disconnect between our two testing methods? |
Implement setting the admin password - Setting occurs during installation or update. - This fixes puppetlabs#24 Use a healthcheck as recommended by the docs - This implements some additional ordering of resources so that ones that require the API are not run before the API is up. Also added 'descr' to yum repo to make the yum command happy
genebean
force-pushed
the
http_conn_validator
branch
from
9610367
to
6d0c4b9
Compare
|
@genebean - this looks good now. I think the only thing we're missing is a Readme update to reflect how password change works. i.e. - the password will be set during the initial install, otherwise, you'll have to trigger a refresh with the addition of some other config change (setting / unsetting ssl would work, as would changing grafana's port) |
|
Given that, should we pull the password stuff back out and just let people change it post-install using one of the fully supported methods? |
|
I just found out that in Grafana 6 you'll be prompted to change the password from the default when you log in for the first time. That means that a user might go with a default configuration, log in, change the password and then end up with failing puppet runs until they update the With that in mind I think we might need a password change mechanism built in. |
You should be able to avoid that by setting these environment variables: This post has some more info on configuring Dockerized Grafana: https://riamf.github.io/posts/dockerized_grafana_setup/ |
|
|
|
@genebean is this something still relevant or has everything moved on too much |
|
This would be a welcome addition but this PR is stale with no updates for over 2 years. I am closing this PR, but please reopen it with changes or open a new one with this feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #25. It implements some additional ordering of resources so that ones that require the API are not run before the API is up.