Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPv6 #3604

Open
wants to merge 2 commits into
base: 6.x
Choose a base branch
from
Open

Add support for IPv6 #3604

wants to merge 2 commits into from

Conversation

jovandeginste
Copy link

I'm not sure if there are other missing parts, but so far it works for us with the changes in this PR.

Traditional `netcat` has no support for IPv6. Support is implemented in
`netcat-openbsd`, which should also be backward compatible.

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
@jovandeginste jovandeginste requested review from a team as code owners November 26, 2021 10:08
@jovandeginste jovandeginste force-pushed the ipv6 branch 2 times, most recently from 79ec355 to 41cc0c3 Compare November 26, 2021 10:12
@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

The equivalent "all" interface to `0.0.0.0` for IPv6 is `::`; this
_includes_ IPv4's `0.0.0.0`. In other words, this should be fully
backward compatible.

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
@jovandeginste
Copy link
Author

Apologies for the force-pushes - I realized I also changed "old" (changelog) documentation, which is probably not to be touched.

@stelcodes
Copy link
Contributor

Hey @jovandeginste, thanks for this PR! The PuppetDB team is a bit overwhelmed with backlog at the moment, but we will discuss these changes as soon as we can.

@jcpunk
Copy link

jcpunk commented Jun 9, 2022

Any news on this? I'd love to have IPv6 working with the puppetdb container.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants