Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-36194) benchmark: when submitting multiple messages backdate timestamps #3818

Merged

Conversation

austb
Copy link
Contributor

@austb austb commented Jun 8, 2023

No description provided.

@austb austb force-pushed the pe-36194/main/backdate-benchmark-commands branch from f1f2ea7 to 4a059c5 Compare June 26, 2023 20:56
@austb austb marked this pull request as ready for review June 26, 2023 21:08
@austb austb requested review from a team as code owners June 26, 2023 21:08
Copy link
Contributor

@jpartlow jpartlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@austb austb force-pushed the pe-36194/main/backdate-benchmark-commands branch from 4a059c5 to 2111fa5 Compare June 28, 2023 21:36
Previously these flags determined the "mode" that benchmark ran in. Now
that will be decided exclusively by the presence or absence of the
nummsgs option.

We need both options because the amount of back-dating needed when
submitting the first reports is effectively (now - (nummsgs *
runinterval)).
@austb austb force-pushed the pe-36194/main/backdate-benchmark-commands branch from 2111fa5 to a2fa354 Compare June 29, 2023 17:39
@puppetlabs-jenkins
Copy link
Contributor

Tests Failed \o/

@austb austb merged commit 937e894 into puppetlabs:main Jun 29, 2023
@austb austb deleted the pe-36194/main/backdate-benchmark-commands branch June 29, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants