Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PE-36193) PDB benchmark can use ssl #3835

Merged
merged 4 commits into from
Jul 19, 2023
Merged

(PE-36193) PDB benchmark can use ssl #3835

merged 4 commits into from
Jul 19, 2023

Commits on Jul 11, 2023

  1. (maint) Remove unused base-url functions 

    This look to have disappeared from use years ago when the cli tooling
changed.
    @jpartlow
    jpartlow committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f672964 View commit details
    Browse the repository at this point in the history

  2. (PE-36193) Use puppetlabs.http.client in puppetdb.client 

    Replaces use of clj-http.client with our puppetlabs.hhtp.client that
provides for https communication when provided certs.  Specifically,
this is to allow benchmark to use https for it's pdb commands. Threads
pdb jetty ssl opts to through to the new http client from benchmark
invocation.
    @jpartlow
    jpartlow committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    82f3cf2 View commit details
    Browse the repository at this point in the history

  3. (PE-36193) Update benchmark docs for https 

    * Adds documentation for using benchmark over https.
* Marks https as the preferred configuration if you are going to run
benchmark off the primary.
* The http configuration docs incorrectly specified that you could lock
down http access to a single agent by setting puppetdb's jetty.host to
the agent ip. The host setting tells puppetdb which interfaces to listen
on on the primary, not which ip's to allow requests from.
* Emphasized that opening http is not recommended as this is insecure and
allows http access from any source.
    @jpartlow
    jpartlow committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b718f02 View commit details
    Browse the repository at this point in the history

  4. (PE-36193) Increase jitter allowance for benchmark rate test 

    ...to account for some slower test runs on macos.
It's also possibly that the puppetlabs client is a bit slower? But I
think I've seen this transient before.
    @jpartlow
    jpartlow committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1e0a0f6 View commit details
    Browse the repository at this point in the history