Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDB-5691) benchmark: space out command types #3880

Merged
merged 2 commits into from
Sep 26, 2023
Merged

(PDB-5691) benchmark: space out command types #3880

merged 2 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. (PDB-5691) benchmark: space out command types 

    To alleviate the certname row contention, this replaces the pipeline
that sends each command separately to the submission pipeline with a
go-loop that schedules the sending of catalogs and reports at a later
time (5-15 seconds delay for each). This should more accurately simulate
the actual behavior and allow more realistic performance testing.

Every command runs scf-storage/maybe-activate-node! which causes
contention on the certname row when multiple commands of the same
certname are processed simultaneously. Previously we generated a set of
commands for a certname and submitted them all at once, so there was
contention on most submissions from benchmark. This is not reflective of
reality because a catalog is delayed by the time it takes puppetserver
to compile the node's catalog after receiving the factset, and the report
is delayed after catalog compilation by the time it takes the agent to
apply it.
    @austb
    austb committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    27bb648 View commit details
    Browse the repository at this point in the history

  2. (PDB-5691) benchmark: update async diagram

    @austb
    austb committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    75c90ed View commit details
    Browse the repository at this point in the history