(GH-3912) add include_catalog_edges config to terminus #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration option to the terminus, `include_catalog_edges` that, when set to `false`, will disable sending any catalog edges to PuppetDB. Profiling of PuppetDB command processing has shown catalog edges can take as much as one third of the total time to process a catalog. Users with many nodes that don't use edges in their queries could benefit quite substantially from using this option. It is not enabled by default to maintain backwards compatibility during PuppetDB 8. Resolves puppetlabs#3912.
austb
force-pushed
the
gh-3912/main/omit-catalog-edges
branch
from
a71c40c
to
8cf4aed
Compare
austb
force-pushed
the
gh-3912/main/omit-catalog-edges
branch
from
8cf4aed
to
f90549d
Compare
jpartlow
approved these changes
Nov 29, 2023
rbrw
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration option to the terminus,
include_catalog_edgesthat, when set tofalse, will disable sending any catalog edges to PuppetDB. Profiling of PuppetDB command processing has shown catalog edges can take as much as one third of the total time to process a catalog. Users with many nodes that don't use edges in their queries could benefit quite substantially from using this option. It is not enabled by default to maintain backwards compatibility during PuppetDB 8.Resolves #3912.