(PDB-5793): Upgraded beaker-hostgenerator gem to add support for debian-12-x86_64 #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveax
approved these changes
Sep 13, 2024
donoghuc
suggested changes
Sep 13, 2024
|
I'm assuming this is platform 8 only? |
span786
force-pushed
the
PDB-5793-upgrade-beaker-hostgenerator-gem-to-support-debian-12-x86_64
branch
from
a5c1a84
to
b248b1a
Compare
Yes, it is for platform 8 only |
span786
force-pushed
the
PDB-5793-upgrade-beaker-hostgenerator-gem-to-support-debian-12-x86_64
branch
from
b248b1a
to
1306ff9
Compare
donoghuc
suggested changes
Sep 23, 2024
There was a problem hiding this comment.
Looks like its targeted at 7 also https://github.com/puppetlabs/puppetdb/pull/4002/files . I think you should close this, merge the other one and do a mergeup. Typically for repos like this we like to target changes at the oldest stream and do mergeups.
|
Merged up from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded beaker-hostgenerator gem to add support for debian-12-x86_64 in beaker tests