Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1688) Upgrade rubocop to ~> 1.50.0 #7

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

LukasAud
Copy link

Following a recent team decision, we are implementing a Rubocop Upgrade, moving the version from 1.48.1 to 1.50.0. This should be the final version until Puppet 7 is unsupported.

Following a recent team decision, we are implementing a Rubocop Upgrade,
moving the version from 1.48.1 to 1.50.0. This should be the final
version until Puppet 7 is unsupported.
@LukasAud LukasAud requested a review from a team as a code owner January 19, 2024 16:19
@LukasAud LukasAud force-pushed the CAT-1688-Upgrade_rubocop branch from aef63f1 to 7099695 Compare January 19, 2024 16:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (409c5c9) 88.77% compared to head (6cb1792) 88.53%.

Files Patch % Lines
lib/puppetfile-resolver/cache/persistent.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   88.77%   88.53%   -0.25%     
==========================================
  Files          34       34              
  Lines         793      776      -17     
==========================================
- Hits          704      687      -17     
  Misses         89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukasAud LukasAud force-pushed the CAT-1688-Upgrade_rubocop branch from 5d1ade7 to 311358c Compare January 22, 2024 14:51
@LukasAud LukasAud changed the title (CAT-1688) Upgrade rubocop (CAT-1688) Upgrade rubocop to ~> 1.50.0 Jan 22, 2024
@LukasAud LukasAud changed the title (CAT-1688) Upgrade rubocop to ~> 1.50.0 (CAT-1688) Upgrade rubocop to ~> 1.50.0 Jan 22, 2024
Co-authored-by: Jordan Breen <112936862+jordanbreen28@users.noreply.github.com>
@jordanbreen28 jordanbreen28 merged commit 1afe627 into main Jan 23, 2024
7 of 8 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-1688-Upgrade_rubocop branch January 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants