Debian 11: fix typo in versioncmp() / set default php to 7.4

[bastelfreak]

tl;dr $::operatingsystemrelease is different from
$::operatingsystemmajrelease. $::operatingsystemmajrelease returns
'11.0' on Debian 11, whereas $::operatingsystemmajrelease is 11.
In addition versioncmp() says that '11.0' is greater than 11.

Without this change, the module sets the default PHP version on Debian
11 to 7.2, but the actual default in Debian is 7.4:

• https://packages.debian.org/bullseye/php

The 7.2 currently comes from the default entry in the selector
statement:

• https://github.com/puppetlabs/puppetlabs-apache/blob/main/manifests/params.pp#L401

To test:

notify { "operatingsystemrelease compared to 11: ${versioncmp($::operatingsystemrelease, '11')}":}
notify { "operatingsystemmajrelease compared to 11: ${versioncmp($::operatingsystemmajrelease, '11')}":}
notify { "operatingsystemrelease: ${::operatingsystemrelease}":}
notify { "operatingsystemmajrelease: ${::operatingsystemmajrelease}":}

which produces:

puppet apply test.pp
Notice: Compiled catalog for blal in environment production in 0.02 seconds
Notice: operatingsystemrelease compared to 11: 1
Notice: /Stage[main]/Main/Notify[operatingsystemrelease compared to 11: 1]/message: defined 'message' as 'operatingsystemrelease compared to 11: 1'
Notice: operatingsystemmajrelease compared to 11: 0
Notice: /Stage[main]/Main/Notify[operatingsystemmajrelease compared to 11: 0]/message: defined 'message' as 'operatingsystemmajrelease compared to 11: 0'
Notice: operatingsystemrelease: 11.0
Notice: /Stage[main]/Main/Notify[operatingsystemrelease: 11.0]/message: defined 'message' as 'operatingsystemrelease: 11.0'
Notice: operatingsystemmajrelease: 11.0
Notice: /Stage[main]/Main/Notify[operatingsystemmajrelease: 11.0]/message: defined 'message' as 'operatingsystemmajrelease: 11'
Notice: Applied catalog in 0.01 seconds

:~> facter operatingsystemmajrelease
11
:~> facter operatingsystemrelease
11.0

The spec tests are copied from #2181
Co-authored-by: Kienan Stewart kienan.stewart@burntworld.ca

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

apache::params is a class

Breaking changes to this file WILL impact these 16 modules (exact match):

• xdrum-puppet
• brucem-ezpublish
• desalvo-bacula
• jlondon-phpmyadmin
• osc-openondemand
• openstack-panko
• openstack-barbican
• openstack-cinder
• openstack-manila
• openstack-neutron
• openstack-aodh
• openstack-ironic
• openstack-mistral
• openstack-zaqar
• openstack-octavia
• openstack-keystone

Breaking changes to this file MAY impact these 11 modules (near match):

• ULHPC-passenger
• camptocamp-catalog_diff
• openstack-cloudkitty
• openstack-vitrage
• openstack-tripleo
• openstack-sahara
• openstack-magnum
• openstack-gnocchi
• openstack-watcher
• willdurand-bazinga
• openstack-heat

This module is declared in 175 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

I also raised a ticket about the versioncmp behaviour: https://tickets.puppetlabs.com/browse/PUP-11235