Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v12.0.0 #2508

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Release prep v12.0.0 #2508

merged 1 commit into from
Jan 2, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 14, 2023

Automated release-prep through pdk-templates from commit af57ff1.
Please verify before merging:

@github-actions github-actions bot requested a review from a team as a code owner December 14, 2023 08:41
@github-actions github-actions bot force-pushed the release-prep branch 2 times, most recently from bbec05b to bb2b53a Compare December 31, 2023 21:57
@github-actions github-actions bot changed the title Release prep v11.2.0 Release prep v12.0.0 Dec 31, 2023
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes move to be displayed before enhancement is expected. LGTM.

@smortex
Copy link
Collaborator

smortex commented Jan 2, 2024

w00t, let's click on buttons and see what happen :-P

Edit: IT LIVES!!

@smortex smortex merged commit 4b316af into main Jan 2, 2024
1 check passed
@smortex smortex deleted the release-prep branch January 2, 2024 01:17
@ekohl
Copy link
Collaborator

ekohl commented Jan 2, 2024

Couldn't we have used this major release to remove more deprecated things? This feels like a very small thing to do a major release over. c9776cf didn't remove anything from metadata.json so anyone using it was already doing something unsupported.

@ekohl
Copy link
Collaborator

ekohl commented Jan 2, 2024

#2512 & #2513 would have been so easy.

@smortex
Copy link
Collaborator

smortex commented Jan 2, 2024

[...] c9776cf didn't remove anything from metadata.json so anyone using it was already doing something unsupported.

Ah, it was mislabelled as a breaking change while it was a maintenance one… I did not double-checked this one, and promoted the new version as a major one :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants