Merge pull request #329 from spuder/spuder/lsbdist

Adds check to params.pp if lab-release is not installed
puppetlabs · Jul 29, 2014 · 256a63b · 256a63b
2 parents 3a2fe3b + 64b8eb1
commit 256a63b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/manifests/params.pp b/manifests/params.pp
@@ -49,6 +49,9 @@
         }
       }
     }
+    '': {
+      fail('Unable to determine lsbdistid, is lsb-release installed?')
+    }
     default: {
       fail("Unsupported lsbdistid (${::lsbdistid})")
     }

diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb
@@ -24,4 +24,16 @@
     end
 
   end
+
+  describe "With lsb-release not installed" do
+    let(:facts) { { :lsbdistid => '' } }
+    let (:title) { 'my_package' }
+
+    it do
+      expect {
+        should compile
+      }.to raise_error(Puppet::Error, /Unable to determine lsbdistid, is lsb-release installed/)
+    end
+  end
+
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,9 @@ @@
             }
           }
         }
+        '': {
+          fail('Unable to determine lsbdistid, is lsb-release installed?')
+        }
         default: {
           fail("Unsupported lsbdistid (${::lsbdistid})")
         }
@@ Expand Down @@