Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-493) PPA validation adjustment #1085

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

LukasAud
Copy link

@LukasAud LukasAud commented Jan 17, 2023

Prior to this commit, one of our updates (#1052) implemented a regex validation for ppa packages that were to be installed. However, this validation did not account for resource names that were dotted.

This commit aims to fix this bug in our validation process so that it works as intended. This PR should fix #1084.

@LukasAud LukasAud requested a review from a team as a code owner January 17, 2023 17:04
@LukasAud LukasAud self-assigned this Jan 17, 2023
@puppet-community-rangefinder
Copy link

apt::ppa is a type

Breaking changes to this file WILL impact these 68 modules (exact match):
Breaking changes to this file MAY impact these 10 modules (near match):

This module is declared in 235 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud force-pushed the CONT-493-ppa_validation_fix branch from 0859f84 to b717c5e Compare January 17, 2023 17:28
Prior to this commit, one of our updates (#1052)
implemented a regex validation for ppa packages that were to be
installed. However, this validation did not account for resource
names that were dotted.

This commit aims to fix this bug in our validation process so that it
works as intended.
@LukasAud LukasAud force-pushed the CONT-493-ppa_validation_fix branch from b717c5e to a14262b Compare January 18, 2023 10:26
@pmcmaw pmcmaw merged commit d11099c into main Jan 18, 2023
@pmcmaw pmcmaw deleted the CONT-493-ppa_validation_fix branch January 18, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validation of ppa breaks ppa
3 participants