apt: Add proxy support on the class. #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most options can and should be named through symbols, makes it much easier to read too with syntax highlighting.
daenney
force-pushed
the
daenney/apt-proxy
branch
from
2d5848f to
fb908ec
Compare
| } | ||
| if $proxy['https'] { | ||
| validate_bool($proxy['https']) | ||
| } |
There was a problem hiding this comment.
Once we can use the type system we'll be able to simply do all this validation with a Struct declaration. How I long for that day...
|
@daenney back to you! |
Re-introduce proxy support at the class level. Needing to configure a proxy is such a common scenario that having it on the class is a reasonable thing. It also affects `apt::ppa`. Change `apt::ppa` to no longer have its own `proxy` parameter but use the proxy as configured on the main `apt` class.
daenney
force-pushed
the
daenney/apt-proxy
branch
from
fb908ec to
d81c3d9
Compare
|
@mhaskel Fixed, your turn! |
underscorgan
pushed a commit
that referenced
this pull request
Feb 27, 2015
apt: Add proxy support on the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce proxy support at the class level. Needing to configure a proxy is such a common scenario that having it on the class is a reasonable thing. It also affects
apt::ppa.Change
apt::ppato no longer have its ownproxyparameter but use the proxy as configured on the mainaptclass.