(MODULES-1156, MODULES-769) Update anchors #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm. I hate anchors. Annoying thing to hook in classes. What I always understood though is that we need two, a start and an end anchor and hook the class in in-between to make sure it can't float off. What am I missing? |
|
hrmm, it's possible this has been wrong for forever then :\ I'll have to do some experimenting with graphs. |
|
hahaha yep. according to docs this has been wrong foreversies. wheeee. |
`apt::ppa` and `apt::setting` don't actually include `apt::update` so anchors are unnecessary. Move `apt` to use contain instead of anchors, since it wasn't anchoring properly anyways. Update the tests to make sure it can have settings and ppas depending on each other without cycles.
underscorgan
force-pushed
the
update_anchors
branch
from
34f3e07 to
911c4de
Compare
|
@daenney so, it actually hasn't been wrong for forever, just since hulk-smashing-removing-unnecessary-includes. This should be better :) |
|
Aha, that's interesting. |
daenney
added a commit
that referenced
this pull request
Mar 25, 2015
(MODULES-1156, MODULES-769) Update anchors
| anchor { 'apt::update': | ||
| require => Class['apt::update'], | ||
| } | ||
| contain 'apt::update' |
There was a problem hiding this comment.
Oh eh, are we sure we need the quotes here?
There was a problem hiding this comment.
um. no. not confident about that at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think our anchors for
Class['apt::update']were backwards since the code was all setting notifies, but we were using requires. This was leading to a bunch of dependency cycle issues.